Fix tool search to support substring matching in name and ID #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_tools(name=query) bioblend API call does not support substring matching and returns empty results for partial matches. This fix changes search_tools_by_name() to: 1. Fetch all tools using get_tools() without the name parameter 2. Filter client-side for substring matches in both tool name and ID 3. Support case-insensitive matching This ensures tools like 'celltypist_predict' are found when searching for 'celltypist', matching the behavior of search_tools_by_keywords. Updated tests to reflect the new behavior where get_tools() is called without parameters and filtering happens client-side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
search_tools_by_name()function was usinggi.tools.get_tools(name=query), which doesn't support substring matching in the Galaxy/bioblend API. This resulted in tools not being found even when they existed in the instance. For example, searching for "celltypist" would return 0 results even though tools likecelltypist_predictexist.This PR changes the implementation to fetch all tools and filter client-side for substring matches in both tool name and ID with case-insensitive matching, matching the behavior already used in
search_tools_by_keywords().Type of Change
Checklist
Related Issues
Closes #
Testing
Verified manually against a production Galaxy instance that celltypist tools are now found when searching for "celltypist", whereas previously they returned 0 results.